On Tue, 27 Feb 2007, Junio C Hamano wrote: > Junio C Hamano <junkio@xxxxxxx> writes: > > > Nicolas Pitre <nico@xxxxxxx> writes: > > > >> We currently have two parallel notation for dealing with object types > >> in the code: a string and a numerical value. One of them is obviously > >> redundent, and the most used one requires more stack space and a bunch > >> of strcmp() all over the place. > >> > >> This is an initial step for the removal of the version using a char array > >> found in object reading code paths. The patch is unfortunately large but > >> there is no sane way to split it in smaller parts without breaking the > >> system. > > Will your next step be to convert write_sha1_file() and friends? Yes, eventually. At least the write paths don't have those strcpy()/strcmp() everywhere and no temporary char arrays on the stack. But for uniformity they have to be converted as well. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html