On 11/15/2014 08:32 AM, Stefan Beller wrote:
> On 14.11.2014 23:26, Michael Haggerty wrote:
>> There is no reason for $GIT_DIR/config to be executable, plus this
>> change will help clean up repositories affected by the bug that was
>> fixed by the previous commit.
>>
>> Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx>
>> ---
>> config.c | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/config.c b/config.c
>> index 9e42d38..0942e5f 100644
>> --- a/config.c
>> +++ b/config.c
>> @@ -1653,7 +1653,15 @@ int git_config_set_multivar_in_file(const char *config_filename,
>> MAP_PRIVATE, in_fd, 0);
>> close(in_fd);
>>
>> - if (chmod(lock->filename, st.st_mode & 07777) < 0) {
>> + /*
>> + * We make of the executable bits because (a) it
>
> We make *use* of
Thanks for catching this. But it's even worse. I meant to type "mask off".
Junio, would you mind fixing this if there is no other reason for a
re-roll? Thanks.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html