On Wed, Nov 12, 2014 at 10:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Johan Herland <johan@xxxxxxxxxxx> writes: >> On Wed, Nov 12, 2014 at 2:57 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: >>> On Tue, Nov 11, 2014 at 7:40 PM, Johan Herland <johan@xxxxxxxxxxx> wrote: >>>> + test_line_count = 1 actual >>> >>> Broken &&-chain. This problem is repeated each place use invoke >>> test_line_count(). >> >> Thanks. Fixed in the next iteration. > > Just FYI, here is what I came up with on top of 9/9 as 10/9, and it > can be squashed in. If these will be the only differences between > v5 and upcoming v6, you can just tell me to squash them together. So far this is the only diff on top of v5. I've squashed it into my tree, so if a re-roll is needed, this diff will also be part of it. But if no other issues show up to trigger a re-roll, then please squash them on your end as well. > One unrelated changes is that '\'' is a bit shorter than '"'"' (and > the four-letter sequence is idiomatic and easier to spot, once your > eyes are used to reading strings in single-quote pairs). Agreed, thanks. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html