On Mon, Nov 10, 2014 at 02:43:10PM -0800, Junio C Hamano wrote: > > Explicitly declare that git_atexit_dispatch() and git_atexit_clear() > > take no parameters instead of leaving their parameter list empty and > > thus unspecified. > [...] > > I was kind of surprised after running a git blame to find that this > is a recent thing, and the same patch looked quite substandard with > numerious style violations, and I somehow managed to let them slip > in X-<. Perhaps I was having a bad day or something... I had always just assumed that -Wstrict-prototypes was part of -Wall, but it is not (nor even part of -Wextra!). Maybe it is time to add it to your integration-build flags. :) Looks like we also need this on top of hv/submodule-config (still in pu, so squashing is probably best): diff --git a/submodule-config.h b/submodule-config.h index 58afc83..9061e4e 100644 --- a/submodule-config.h +++ b/submodule-config.h @@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1, const char *name); const struct submodule *submodule_from_path(const unsigned char *commit_sha1, const char *path); -void submodule_free(); +void submodule_free(void); #endif /* SUBMODULE_CONFIG_H */ -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html