On Mon, Nov 10, 2014 at 7:17 PM, Michael Blume <blume.mike@xxxxxxxxx> wrote: > the commit modernizing test 3301 > (https://github.com/git/git/commit/fbe4f74865acfd) appears to break it > on my mac > > $ ./t3301-notes.sh -v > expecting success: > MSG=b4 git notes add && > test_path_is_missing .git/NOTES_EDITMSG && > test "1" = "$(git ls-tree refs/notes/commits | wc -l)" && > test "b4" = "$(git notes show)" && > git show HEAD^ && > test_must_fail git notes show HEAD^ > > b4 > not ok 8 - create notes This and all other failures are due to the output of 'wc -l', which on Mac is "{whitespace}1" rather than just "1" as it is on other platforms. fbe4f748 added quotes around the $(... | wc -l) invocation which caused the whitespace to be retained. A minimum fix would be to drop the quotes surrounding $(). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html