On Sun, Nov 09, 2014 at 02:49:58PM +0100, René Scharfe wrote: > -- >8 -- > Subject: [PATCH] trailer: use CHILD_PROCESS_INIT in apply_command() > > Initialize the struct child_process variable cp at declaration time. > This is shorter, saves a function call and prevents using the variable > before initialization by mistake. > > Suggested-by: Jeff King <peff@xxxxxxxx> > Signed-off-by: Rene Scharfe <l.s.r@xxxxxx> > --- > trailer.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, both this one and the other you just sent (to use child_process.args in more places) look good to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html