Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > Yeah, it won't be as efficient as using only one strbuf and only byte > oriented functions, and it looks much less manly too :-) But over time in > Git we have developed a number of less efficient but quite clean > abstractions like strbuf, argv_array, sha1_array and so on, that we > are quite happy with. Actually, all these examples you gave are fairly efficient and clean abstractions. I find it insulting to pretend that the "one line per strbuf" is in the same league. It isn't. And it is not about manliness. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html