Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zitat von Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>:

Commit d57da44b1 ("imap-send: use libcurl for implementation",
06-11-2014) updates the implementation of the imap-send command
to make use of libcurl's high(er)-level API functions.

In doing so, this introduces a sparse warning about "using sizeof
on a function". In order to suppress the warning, we use the same
solution used in commit 9371322a6 ("sparse: suppress some "using
sizeof on a function" warnings", 06-10-2013) which solved exactly
this problem for the other commands using libcurl.

Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>
---

Hi Bernhard,

If you need to re-roll your 'br/imap-send-via-libcurl' branch, could
you please squash this into your patch.

Thanks!

Hi Ramsay,

and thanks for your fix! TBH, I didn't even notice that my patch had already been committed and instead posted a refined version earlier today [1] (which unfortunately didn't contain your fix, either).

Not sure how to proceed. Maybe Junio can enlighten?

Regards
Bernhard

[1] http://www.mail-archive.com/git@xxxxxxxxxxxxxxx/msg60576.html

ATB,
Ramsay Jones

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 1ded274..0fc2790 100644
--- a/Makefile
+++ b/Makefile
@@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX
 gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
 	-DGIT_LOCALE_PATH='"$(localedir_SQ)"'

-http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \
+http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp: SPARSE_FLAGS += \
 	-DCURL_DISABLE_TYPECHECK

 ifdef NO_EXPAT
--
2.1.0


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]