Re: [PATCH 18/19] update-index: test the system before enabling untracked cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 29, 2014 at 12:37 AM, Torsten Bögershausen <tboegi@xxxxxx> wrote:
> On 2014-10-27 13.10, Nguyễn Thái Ngọc Duy wrote:
> []
>
>> +static void xmkdir(const char *path)
>> +{
>> +     if (mkdir(path, 0700))
>> +             die_errno(_("failed to create directory %s"), path);
>> +}
>
> Does it makes sense to ignore EINTR and do a "retry" ?
> Another question is if the function could be called mkdir_or_die() instead?
>
> I realized that there are 2 families of xfunc() in wrapper.c, some die, some retry.

This is only used interactively, I think it's ok to ignore EINTR as
long as we report clearly the case (and hope the user to re-enter the
command)
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]