On Sun, Oct 26, 2014 at 1:33 PM, David Michael <fedora.dm0@xxxxxxxxx> wrote: > The XL C compiler can fail due to mixing library path and object Can you explain in the commit message the actual nature of the failure so that readers can understand more precisely how this change helps? > file arguments, for example when linking git while building with > "gmake LDFLAGS=-L$prefix/lib". This moves the ALL_LDFLAGS variable > expansion in the git executable rule to be consistent with all the > other linking rules. > > Signed-off-by: David Michael <fedora.dm0@xxxxxxxxx> > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index fcd51ac..827006b 100644 > --- a/Makefile > +++ b/Makefile > @@ -1610,8 +1610,8 @@ git.sp git.s git.o: EXTRA_CPPFLAGS = \ > '-DGIT_INFO_PATH="$(infodir_relative_SQ)"' > > git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS) > - $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ git.o \ > - $(BUILTIN_OBJS) $(ALL_LDFLAGS) $(LIBS) > + $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) git.o \ > + $(BUILTIN_OBJS) $(LIBS) > > help.sp help.s help.o: common-cmds.h > > -- > 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html