Avoid: # ./t1304-default-acl.sh ok 1 - checking for a working acl setup ok 2 - Setup test repo not ok 3 - Objects creation does not break ACLs with restrictive umask # # # SHA1 for empty blob # check_perms_and_acl .git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 # not ok 4 - git gc does not break ACLs with restrictive umask # # git gc && # check_perms_and_acl .git/objects/pack/*.pack # # failed 2 among 4 test(s) 1..4 on systems where USER isn't set. It's usually set by the login process, but it isn't set when launching some Docker images. For example: $ docker run --rm debian env HOME=/ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOSTNAME=b2dfdfe797ed 'id -u -n' has been in POSIX from Issue 2 through 2013 [1], so I don't expect compatibility issues. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/id.html Signed-off-by: W. Trevor King <wking@xxxxxxxxxx> --- The patch is based on the current maint branch. Previous LOGNAME discussion: * Michael Gruber on 2011-05-06 suggesting a discussing a whoami fallback [1] (but whoami isn't POSIX). * René Scharfe on 2011-10-14 suggesting USER as a fallback for LOGNAME [2]. * Matthieu Moy on 2012-09-17 suggesting dropping $LOGNAME in favor of numerical user IDs 'id -u' for a system with multiple usernames sharing the same user ID [3]. Obviously, you can work around the problem with: # USER=$(id -u -n) ./t1304-default-acl.sh so the question is really "Are empty-USER systems worth supporting out of the box?". Cheers, Trevor [1]: http://thread.gmane.org/gmane.comp.version-control.git/172883/focus=172961 [2]: http://thread.gmane.org/gmane.comp.version-control.git/183586 [3]: http://thread.gmane.org/gmane.comp.version-control.git/205690/focus=205703 t/t1304-default-acl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh index 79045ab..f5422f1 100755 --- a/t/t1304-default-acl.sh +++ b/t/t1304-default-acl.sh @@ -26,7 +26,7 @@ test_expect_success 'checking for a working acl setup' ' if test -z "$LOGNAME" then - LOGNAME=$USER + LOGNAME="${USER:-$(id -u -n)}" fi check_perms_and_acl () { -- 2.1.0.60.g85f0837 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html