Re: [PATCH] core.filemode may need manual action

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 16 Oct 2014, Thomas Braun wrote:

> Am 16.10.2014 um 21:29 schrieb Torsten Bögershausen:
> > core.filemode is set automatically when a repo is created.
> > But when a repo is exported via CIFS or cygwin is mixed with Git for Windows
> > core.filemode may better be set manually to false.
> > Update and improve the documentation.
> > 
> > Helped-by: Junio C Hamano <gitster@xxxxxxxxx>
> > Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
> > ---
> > 
> > Does this reflect the discussion via email ?
> > Or is more tweaking needed ?
> > 
> > 
> >  Documentation/config.txt | 19 +++++++++++++++++--
> >  1 file changed, 17 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/config.txt b/Documentation/config.txt
> > index 4333636..b4fea43 100644
> > --- a/Documentation/config.txt
> > +++ b/Documentation/config.txt
> > @@ -204,8 +204,23 @@ advice.*::
> >  --
> >  
> >  core.fileMode::
> > -	If false, the executable bit differences between the index and
> > -	the working tree are ignored; useful on broken filesystems like FAT.
> > +	Tells Git if the executable bit of files in the working tree
> > +	is to be honored.
> > +
> > +	Some filesystems lose the executable bit when a file that is
> > +	marked as executable is checked out, or checks out an
> > +	non-executable file with executable bit on.  "git init" and
> > +	"git clone" probe the filesystem to see if it records
> > +	executable bit correctly when they create a new repository
> > +	and this variable is automatically set as necessary.
> > +
> > +	A repository, however, may be on a filesystem that records
> > +	the filemode correctly, and this variable is set to 'true'
> > +	when created, but later may be made accessible from another
> > +	environment that loses the filemode (e.g. exporting ext4 via
> > +	CIFS mount, visiting a Cygwin managed repository with
> > +	MsysGit).  In such a case, it may be necessary to set this
> > +	variable to 'false'.
> >  	See linkgit:git-update-index[1].
> >  +
> >  The default is true, except linkgit:git-clone[1] or linkgit:git-init[1]
> > 
> 
> [CC'ing msysgit aka git-for-windows/sdk for input]
> 
> I'm not really happy with the term MsysGit here.
> Would it be too bold to say
> [... ] visiting a Cygwin managed repository with Git for Windows.
> ?

I agree that msysGit is the wrong term. Not only is it about to be
replaced by the Git for Windows SDK, it is *actively* wrong because
msysGit is just the *development environment* to build Git for Windows.
Most users do *not* need msysGit at all.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]