Re: DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 09, 2014 at 12:53:33PM -0500, Derek Moore wrote:

> Following the INSTALL doc, I was building git with:
> 
> make prefix=/usr/local all doc info

I wonder if it is actually sane to recommend building "info" for
newcomers in INSTALL. I do not know if many of the list regulars do so
(I certainly do not), or if it is part of anybody's testing regimen.

> $ git diff
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index cea0e7a..0e6c70a 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -107,7 +107,7 @@ HTML_REPO = ../../git-htmldocs
> 
>  MAKEINFO = makeinfo
>  INSTALL_INFO = install-info
> -DOCBOOK2X_TEXI = docbook2x-texi
> +DOCBOOK2X_TEXI = db2x_docbook2texi
>  DBLATEX = dblatex
>  ASCIIDOC_DBLATEX_DIR = /etc/asciidoc/dblatex
>  ifndef PERL_PATH

I don't think we would want to take a patch like this, as it is still
called docbook2x-texi at least on Debian.

You can override variables with:

  make DOCBOOK2X_TEXI=db2x_docbook2texi ...

or if you want to use it for multiple make invocations:

  echo DOCBOOK2_TEXI=db2x_docbook2texi >config.mak

If we want a patch to make this Just Work out of the box on Fedora, I'd
suggest looking at config.mak.uname (though I am not sure if there is
enough information there currently to determine Fedora versus another
distro), and/or a patch to configure.ac to detect which name we have.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]