Re: [msysGit] [PATCH v4] MinGW(-W64) compilation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marat,

On Wed, 8 Oct 2014, Marat Radchenko wrote:

> On Wed, Oct 08, 2014 at 11:40:17AM +0200, Johannes Schindelin wrote:
> > To make it easier to review and substantially easier to work on this patch
> > series with Git, I opened a pull request on GitHub:
> >
> >       https://github.com/msysgit/git/pull/264
> >
> 
> 1. I fail to see how using a tool that doesn't send emails about review
>    comments is *easier* than just sending emails.

You probably missed how I commented on exact lines without you having to
guess from the quoted context what part of your patches I am talking
about.

You probably also missed the fact that comments on rewritten commits
automatically drop out of sight, decluttering the set of comments and
making it obvious which comments have not been addressed yet.

And finally, you probably also missed the fact that the official Git fork
for Windows was asked to review your patches because Junio defers
Windows-specific stuff to us. And as you refused to work against our
integration branches (yes, we have two, because we are working towards
switching to a more sustainable development environment, something you
already mocked successfully), we had to rebase your work onto two
branches, which is also substantially easier to do using GitHub rather
than via mails.

But I get it: you want to roll your own thing and not help us review it
let alone make use of it. That's fine, we'll manage.

> 2. Please, do not hijack patchset discussion by moving it from git@ ML to 
>    GitHub comments.

I mistook your work on Git and the fact that you have an account on GitHub
for your willingness to collaborate on this effectively. My mistake, I
apologize!

> 3. And I repeat, my goal is to push this stuff in git.git,
>    not in msysgit.git, not in git-for-windows.git, not in msys2.git, not in other
>    4k+ forks on GitHub.

Yes, your objection is noted.

Junio, we'll take it from here, don't worry.

Ciao,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]