On Wed, Oct 01, 2014 at 01:10:12PM +0200, René Scharfe wrote: > >I wonder if it is worth adding a test (you test only that "not found" > >produces a negative index, but not which index). Like: > > api-sha1-array.txt says about sha1_array_lookup: "If not found, returns a > negative integer", and that's what the test checks. Hmm. I do not recall intentionally leaving the value unspecified; I think it is more that I was simply not thorough when writing the documentation. That being said... > I actually like that the value is not specified for that case because no > existing caller actually uses it and it leaves room to implement the > function e.g. using bsearch(3). Yeah, if no callers actually care right now, that is a reasonable argument for leaving the exact return value unspecified (and testing only what the documentation claims). > I agree that adding a "lookup non-existing entry with duplicates" test would > make t0064 more complete, though. Agreed. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html