Ben Walton <bdwalton@xxxxxxxxx> writes:
> The askpass script that is created for use by the test suite should
> use SHELL_PATH for its hash bang instead of /bin/sh. Commit 5a4352024
> introduced the use of idioms not supported in some legacy /bin/sh
> implementations.
>
> Use write_script to ensure this happens automatically. This lets us
> remove the chmod step as well, since write_script handles that.
>
> Signed-off-by: Ben Walton <bdwalton@xxxxxxxxx>
> ---
I'll leave out the "some legacy shells we do not support want to use
`command`" from the justification of this change. Use of the
write_script helper is the right thing to do---$SHELL_PATH points at
the shell the user told us s/he wants to use, and that is a reason
enough for this change. The reason why the user wants to use that
shell is immaterial.
Thanks.
> t/lib-credential.sh | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/t/lib-credential.sh b/t/lib-credential.sh
> index 9e7d796..d8e41f7 100755
> --- a/t/lib-credential.sh
> +++ b/t/lib-credential.sh
> @@ -278,12 +278,10 @@ helper_test_timeout() {
> '
> }
>
> -cat >askpass <<\EOF
> -#!/bin/sh
> +write_script askpass <<\EOF
> echo >&2 askpass: $*
> what=$(echo $1 | cut -d" " -f1 | tr A-Z a-z | tr -cd a-z)
> echo "askpass-$what"
> EOF
> -chmod +x askpass
> GIT_ASKPASS="$PWD/askpass"
> export GIT_ASKPASS
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html