Re: [PATCH] Add test-chmtime: a utility to change mtime on files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 24 Feb 2007, Eric Wong wrote:

> This is intended to be a portable replacement for our usage
> of date(1), touch(1), and Perl one-liners in tests.

This is a cute idea!

> diff --git a/Makefile b/Makefile
> index e51b448..105f3ec 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -829,7 +829,7 @@ GIT-CFLAGS: .FORCE-GIT-CFLAGS
>  
>  export NO_SVN_TESTS
>  
> -test: all
> +test: all test-chmtime$X

That is nice! This says that the program should be only compiled before 
running the tests. However, you can run the tests also by "cd t; make", 
and even by "cd t; sh tDDDD-*.sh", so I think a check in the tests should 
be added, which tests for executability of test-chmtime.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]