Re: Bug/request: the empty string should be a valid git note

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 20, 2014, at 18:44, Johan Herland wrote:

At least, we should fix

   git notes add -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391

Whether we should also change

   git notes add -m ''

to create an empty note, or leave it as-is, (i.e. similar in spirit to
"git commit -m ''"), I'll leave up to further discussion.

The help for git commit has this:

  --allow-empty-message
    Like --allow-empty this command is primarily for use by
    foreign SCM interface scripts. It allows you to create
    a commit with an empty commit message without using
    plumbing commands like git-commit-tree(1).

Why not add the same/similar option to git notes add?

So this:

  git notes add --allow-empty-message -m ''

creates an empty note.  (Perhaps --allow-empty-note should
be an alias?)

With your patch to allow -C e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
there's already support for it, it just needs the option
parsing added.  :)

--Kyle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]