Re: strange date generated by git-format-patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

>> That is just a fake random date to make the Unix-From line recognizable 
>> by common MUA and does not have anything to do with your commit objects.
>
> So how about this:

> @@ -174,7 +174,7 @@ void show_log(struct rev_info *opt, const char *sep)
>  		else
>  			subject = "Subject: ";
>  
> -		printf("From %s Mon Sep 17 00:00:00 2001\n", sha1);
> +		printf("From %s %s\n", sha1, show_date(time(NULL), 0, 0));

I actually once tried to change it to git's birthday (Thu Apr 7
15:13:13 2005 -0700) and I recall that it turned out that some
people's scripts (or perhaps MUA) were broken and cared what was
before "7" (nothing, as show_date() does, " " to align to two
columns per date, "0" to zero-pad align) on the Unix-From line
and discarded that update.

I do not think it is worth changing it.  Who's hurting with the
current behaviour?  In other words, is it broken?  Unix-From
lines are there only to separate each piece of e-mail in the
mbox and otherwise is not used.  send-email, am, nor imap-send
should care anything beyond the leading "From ", and mailsplit
validates only that what's around the last colon near the end of
line looks like time and year.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]