On 09/13/2014 01:57 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: >>> Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > >>>> so I'll send a reroll of the series as-is in an hour or so. >> >> Jonathan: Is a current version of this patch series set up for review in >> Gerrit? > > Yes. > (https://code-review.googlesource.com/#/q/project:git+topic:ref-transaction) I just worked through the patch series, leaving lots of comments in Gerrit. Overall it looks pretty good and makes a lot of very worthwhile progress. The only patch that gives me a bit of heartburn is [PATCH 15/19] refs.c: fix handling of badly named refs not because it is necessarily wrong, but because it has a lot of non-local effects that are hard to evaluate. I made a bunch of comments in Gerrit about that patch, too, and will wait for a response before having another go at it. Thanks for all your hard and detailed work, Ronnie and Jonathan! Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html