Michael Haggerty wrote: > After commit_lock_file() is called, then the lock_file object is > necessarily either committed or rolled back. So there is no need to > call rollback_lock_file() again in either of these cases. > > Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx> This seems to involve an unadvertised behavior change: before it wouldn't call git_config_clear() on failure, and after the patch it would. Intended? I think it would be clearer with the goto for exception handling maintained (and just a second 'lock = NULL' assignment). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html