Hi, On Fri, 23 Feb 2007, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Since most servers will not have a no-progress aware upload-pack, how > > about this? (It is slightly ugly, but at least works...) > > Please no. > > What's "slight" about this ugliness? > > > + if (no_progress && band != 3 && len > 7 + 5 && > > + !prefixcmp(buf + 7 + len - 5, "done\r")) > > + continue; This is not the part I found ugly. In sideband, there is a lot of 7+len, 8+len, buf+7. The part I found ugly is having to touch builtin-archive.c But I agree that we should not include that in mainline git. But at least this patch is in the open for people who care deeply about no-progress _now_... Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html