On Wed, Sep 3, 2014 at 2:16 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: >> >>> In the --auto code path, gc_before_repack() is called once in parent >>> process then again in the forked process. Stop the second run. >> >> Hmph. Is the true reason why this happens because we have two calls >> to gc_before_repack() in the main, and one is before daemonize()? >> Shouldn't this protection be in the caller? > > Actually, I think the function already is protecting wastage of > getting called twice by saying "I've done pack-refs already" and > "I've done prune-reflogs already" by setting the two variables to > zero. Isn't that sufficient? > > What problem is this patch trying to fix? Oops. I missed that (and should have verified the problem in the first place). Sorry for the noise. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
