On Fri, 2014-08-29 at 12:21 -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > On Wed, Aug 27, 2014 at 06:10:12PM -0400, David Turner wrote: > > > >> It looks like git fsck exits with 0 status even if there are some > >> errors. The only case where there's a non-zero exit code is if > >> verify_pack reports errors -- but not e.g. fsck_object_dir. > > > > It will also bail non-zero with _certain_ tree errors that cause git to > > die() rather than fscking more completely. > > Even if git does not die, whenever it says broken link, missing > object, or object corrupt, we set errors_found and that variable > affects the exit status of fsck. What does "some errors" exactly > mean in the original report? Dangling objects are *not* errors and > should not cause fsck to report an error with its exit status. error in tree 9f50addba2b4e9e928d9c6a7056bdf71b36fba90: contains duplicate file entries (at least -- there might be more, but that's the one that bit me) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html