Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-08-29 at 09:42 -0700, Jacob Keller wrote:
> From: Jonas 'Sortie' Termansen <sortie@xxxxxxxxx>
> 
> This hasn't been a problem in practice as almost all systems have the
> setitimer() API (or it is provided by git in the case of mingw). This code
> wasn't used in any default circumstances, as the build system never sets
> NO_STRUCT_ITIMERVAL - this breakage only occured if the user asked for it.
> 
> We repair this case so we can rely on it in the following commits.
> 
> Signed-off-by: Jonas 'Sortie' Termansen <sortie@xxxxxxxxx>
> ---

I fixed up Jonas' series and tried to resolve the issues I found as well
as re-ordered the patches so that they fit what Junio requested. I also
modified the last two patches to make timer_settime fallback to
setitimer. I am not sure this is the best approach, but it should be
easy to take at least the obvious bug fixes from the first three
patches, and this gives an outline for how we could wrap the setitimer
stuff.

One could also write another layer of wrapper in some compat/itimer.c
code, but I don't think this is necessary.

Regards,
Jake
��.n��������+%������w��{.n��������n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]