[PATCH] builtin/commit.c: fix type warnings from gcc and sparse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 32-bit platforms (only), gcc and sparse both issue warnings
about the type of the pointer expression passed as the third
argument to find_commit_header().  In order to suppress the
warnings, we simply change the type of the 'len' variable to
size_t.

Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>
---

Hi Jeff,

If you need to re-roll your 'jk/commit-author-parsing' series, could
you please squash this into the equivalent of commit 95b5989
("determine_author_info(): reuse parsing functions", 27-08-2014).

Thanks!

ATB,
Ramsay Jones

 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index a9bef73..7cb9981 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -583,7 +583,7 @@ static void determine_author_info(struct strbuf *author_ident)
 
 	if (author_message) {
 		struct ident_split ident;
-		unsigned long len;
+		size_t len;
 		const char *a;
 
 		a = find_commit_header(author_message_buffer, "author", &len);
-- 
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]