On 29 авг. 2014 г., at 2:30, Junio C Hamano <gitster@xxxxxxxxx> wrote: > You may have been concentrating on the "delete root" case, but as > long as you claim "We add a series to test filedelete command", it > would be sensible to test more typical cases of deleting files, not > the entire tree as well, no? Perhaps add three paths in the initial > commit e.g. hello.c, good/night.txt and good/bye.txt, first remove > good/night.txt and validate the result, then remove good/ directory > and validate the result, and finally remove the whole thing and > validate the result, or something like that? Sure, I’ll add more tests for filedelete command. > In a patch series that introduces a demonstration of existing > breakage and then fixes the breakage in a separate patch, mark the > test that shows the known breakage with test_expect_failure and then > turn that line into test_expect_success in the later patch that > fixes the breakage. Ok, thanks.-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html