Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shawn Pearce wrote:

> The implementation sends an LF, but the protocol documentation was
> missing this detail.
>
> Signed-off-by: Shawn Pearce <spearce@xxxxxxxxxxx>
> ---
>  Documentation/technical/pack-protocol.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index 18dea8d..569c48a 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -467,7 +467,7 @@ references.
>  ----
>    update-request    =  *shallow command-list [pack-file]
>  
> -  shallow           =  PKT-LINE("shallow" SP obj-id)
> +  shallow           =  PKT-LINE("shallow" SP obj-id LF)

In git, the client sends LF and the server is happy with or
without LF.  JGit and libgit2 don't send 'shallow' lines.

Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

>  
>    command-list      =  PKT-LINE(command NUL capability-list LF)
>  		       *PKT-LINE(command LF)
> -- 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]