On Mon, Aug 25, 2014 at 10:16:52AM -0700, Ronnie Sahlberg wrote: > Print an error before returning when pack_data is NULL ? I don't think so. We call end_packfile in some code paths (like the die handler) as "close if it's open". So I think it makes sense for it to be a noop if nothing is open. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html