On Aug 22, 2014, at 6:31 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Steffen Prohaska <prohaska@xxxxxx> writes:
>
>>>> + if (limit == -1) {
>>>> + const char *env = getenv("GIT_MMAP_LIMIT");
>>>> + limit = env ? atoi(env) * 1024 : 0;
>>
>> ... this should then be changed to atol(env), and ...
>
> In the real codepath (not debugging aid like this) we try to avoid
> atoi/atol so that we can catch errors like feeding "123Q" and
> parsing it as 123.
>
> But it is OK to be loose in an debugging aid. If I were doing
> this code, I actually would call git_parse_ulong() and not
> define it in terms of kilobytes, though.
Thanks for suggesting this. I wasn't aware of git_parse_ulong().
I think it makes very much sense to use it, even though it's only a
testing aid.
I'll send a PATCH v5 series.
Steffen
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html