Jeff King <peff@xxxxxxxx> writes: > On Wed, Aug 20, 2014 at 08:55:52PM +1200, Chris Packham wrote: > >> I actually find the existing behaviour useful. If I want to disable a >> hook to I can just chmod -x .git/hook/... and I then chmod +x it when >> I want to re-enable it. I guess I could live with an extra warning as >> long as the command still succeeds. > > You could do the same thing "mv $hook $hook.disabled" but it involves > retraining your fingers. I kind of agree that the existing system of > respecting the executable bit is nice, though: it does what you told it > to do, and a misconfiguration is your problem, not the system's. It's > perhaps worth changing if people frequently get the executable-bit thing > wrong, but I don't know whether they do or not. > > I kind of feel like we had a similar discussion around items in PATH, > but I don't remember how it resolved. I don't either, but IIRC the primary tricky point was what happens when a component of $PATH list is inaccessible, making us unable to even know if an executable we are looking for exists there or not, which is slightly a different issue. And I also kind of agree that the existing system is nice. It may sound like a good idea to warn when there is even a slight chance of misconfiguration on the user's side, but for this particular one, it has been a designed-in behaviour for a long time, and it may be unwise to change it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html