David Turner <dturner@xxxxxxxxxxxxxxxx> writes: >On Mon, 2014-07-21 at 14:06 -0700, Junio C Hamano wrote: >> David Turner <dturner@xxxxxxxxxxxxxxxx> writes: >> >> > Introduce the GIT_GUI_LIB_DIR environment variable, to tell git-gui >> > where to look for TCL libs. This allows a git-gui which has been >> > built with a prefix of /foo to be run out of directory /bar. This is >> > the equivalent of GIT_EXEC_PATH or GITPERLLIB but for git-gui's TCL >> > libraries. >> > >> > Signed-off-by: David Turner <dturner@xxxxxxxxxxx> >> > --- >> > git-gui/Makefile | 3 ++- >> > git-gui/git-gui.sh | 6 +++++- >> > 2 files changed, 7 insertions(+), 2 deletions(-) >> >> Would a similar change to gitk necessary/beneficial to platforms >> that would benefit from this change? > >Apparently not; it seems to work fine for me from an alternate location. >Convenient! > >> git-gui directory in my tree comes from its upstream repository >> git://repo.or.cz/git-gui.git/, and it is maintained by Pat Thoyts >> (Cc'ed). > >> Note that these two upstream projects do not have leading >> directories git-gui and gitk-git themselves (they are merged to my >> tree while their paths being renamed). A patch that is appliable to >> them would touch paths without them (e.g. Makefile and git-gui.sh >> for an equivalent of the patch I am responding to). > >Pat, do you want patches via the git mailing list, personal mail, or >some other way? > The standard method is both: personal to ensure I see it and mailing list to allow everyone to comment. I've applied this patch to git-gui master. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html