Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: >>> Why is this needed? Are you now using key_value_info outside config.c? >>> Or is it a leftover from a previous experiment? >> >> Has this been resolved in the new round? > > Tanay explained in another subthread why this was needed. For callers > iterating over the string_list who want to get the file/line info, they > need to be able to cast the void * pointer to struct key_value_info *. For callers that want to see all the multi-values, it would be preferrable for the iterator to pass the filename and the linenumber to the callback function, instead of exposing its implementation detail as a single string list and telling them to pick it apart, no? Not a very convincing argument, but OK for now in the sense that we can fix it later if we wanted to before it gets too late. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html