Re: [PATCH v8 8/8] add tests for `git_config_get_string_const()`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tanay Abhra <tanayabh@xxxxxxxxx> writes:

> +test_expect_success 'find string value for a key' '
> +	check_config get_string case.baz hask &&
> +	check_config expect_code 1 get_string case.ba "Value not found for \"case.ba\""
> +'
> +
> +test_expect_success 'check line error when NULL string is queried' '
> +	test_expect_code 128 test-config get_string case.foo 2>result &&
> +	grep "line 7.*.git/config\|.git/config.*line 7" result
> +'

This is still dependant on the locale ("line" is translated). You need
to use test_i18ngrep instead of grep here (see its definition and
comment in t/test-lib.sh).

I don't think you need these two alternatives OTOH.

BTW, Junio, I don't understand your remark "This test is too tight (the
full string)" in the previous iteration. Can you elaborate?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]