I'll address the comments about style in a revised patch. On Aug 4, 2014, at 9:03 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> + return apply_filter(path, 0, 0, -1, 0, ca.drv->clean); > > What's the significance of "-1" here? Does somebody in the > callchain from apply_filter() check if fd < 0 and act differently > (not a complaint nor rhetoric question)? The decision in apply_filter() to return before the real work is taken on the first 0. Any value for fd would be ok. The -1 is only a reminder that the fd is invalid. Steffen -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html