Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Mon, Aug 4, 2014 at 11:45 AM, Matthieu Moy > <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >> Tanay Abhra <tanayabh@xxxxxxxxx> writes: >> >>> `git_pretty_formats_config()` continues without checking git_config_string's >>> return value which can lead to a SEGFAULT. >> >> Indeed, without the patch: >> >> $ git -c pretty.my= log --pretty=my >> error: Missing value for 'pretty.my' >> zsh: segmentation fault git -c pretty.my= log --pretty=my > > This probably should be formalized as a proper test and included with > Tanay's patch. Not sure it's worth the trouble: the bug corresponds to a mis-application of a pattern used in tens of places in Git's code (basically, each call to git_config_string, 50 callsites). Testing this particular case does not ensure non-regression, and testing all occurences of the pattern would be overkill IMHO. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html