Re: [PATCH] Teach diff -B about colours

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> Matthias Lederhofer noticed that `diff -B` did not pick up on diff 
> colournig.

sp.?

> -static void copy_file(int prefix, const char *data, int size)
> +static void copy_file(int prefix, const char *data, int size,
> +		const char *set, const char *reset)
> ...
>  	if (!nl_just_seen)
> -		printf("\n\\ No newline at end of file\n");
> +		printf("%s\n\\ No newline at end of file\n", reset);
>  }

Are you sure about this one?  If preimage lacked terminating LF and
the postimage has it, then don't you want to see "\ No..." as an
addition?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]