Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
> Tanay Abhra <tanayabh@xxxxxxxxx> writes:
>
>> Signed-off-by: Tanay Abhra <tanayabh@xxxxxxxxx>
>
> I think I deserve a bit of credit here ;-).
>
>> {
>> - return git_config_with_options(fn, data, NULL, 1);
>> + if (git_config_with_options(fn, data, NULL, 1) < 0)
>> + /*
>> + * git_config_with_options() normally returns only
>> + * positive values, as most errors are fatal, and
>> + * non-fatal potential errors are guarded by "if"
>> + * statements that are entered only when no error is
>> + * possible.
>> + *
>> + * If we ever encounter a non-fatal error, it means
>> + * something went really wrong and we should stop
>> + * immediately.
>> + */
>> + die("Unknown error occured while reading the configuration files");
>> }
>
> My bad, but this should be die(_("..."));, so that the message can be
> translated. Not really serious since it's not really meant to be seen by
> the user, though.
Also, other error messages do not start with a capital, hence it should
be "unknown..., not "Unknown. My bad again.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html