David Kågedal <davidk@xxxxxxxxxxxxxx> writes:
> Junio C Hamano <junkio@xxxxxxx> writes:
>
>> We have too many strncmp(a, b, strlen(b)).
>>
>> Signed-off-by: Junio C Hamano <junkio@xxxxxxx>
>> ---
>> git-compat-util.h | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/git-compat-util.h b/git-compat-util.h
>> index 9863cf6..0a9ac56 100644
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -279,4 +279,9 @@ static inline int sane_case(int x, int high)
>> return x;
>> }
>>
>> +static inline int prefixcmp(const char *a, const char *b)
>> +{
>> + return strncmp(a, b, strlen(b));
>> +}
>> +
>> #endif
>
> Is it just me, or coudln't this be a little more self-documenting. I
> find it annoying to have to read through a functions implementation to
> figure out what to pass to it.
>
> If a doc comment is too much, just naming the parameters is often
> enough.
>
> +static inline int prefixcmp(const char *s, const char *prefix)
Thanks. That is much much better.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html