Since the argument to `--recurse-submodules` is mandatory, it does not need to be stuck to the option with `=`. Signed-off-by: John Keeping <john@xxxxxxxxxxxxx> --- Change since v1: - Fix typo --recurse{_ => -}submodules - Dropped previous patch 1/4 adding ";;" at the end of the "--repo" case contrib/completion/git-completion.bash | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 7a6e1d7..bed3665 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand" _git_push () { case "$prev" in + --recurse-submodules) + __gitcomp "$__git_push_recurse_submodules" + return + ;; --repo) __gitcomp_nl "$(__git_remotes)" return -- 2.0.1.472.g6f92e5f.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html