Tanay Abhra <tanayabh@xxxxxxxxx> writes: > On 7/21/2014 6:21 PM, Matthieu Moy wrote: >> 2) Add a by-address parameter to git_configset_get_value that allows the >> user to get the file and line information. In your previous patch, >> that would mean returning a pointer to the corresponding struct >> key_source. > > Will this extra complexity be good for "git_configset_get_value"? > Instead can we provide a function like die_config(char *key) > which prints > die("bad config file line %d in %s", linenr, filename);? Where would you call this function, and where would you take linenr and filename? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html