Re: [PATCH v10 4/4] test-config: add tests for the config_set API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Tanay Abhra <tanayabh@xxxxxxxxx> writes:
>
>> +test_expect_success 'proper error on non-existant files' '
>> +	echo "Error (-1) reading configuration file non-existant-file." >expect &&
>
> s/tant/tent/ perhaps?
> cf. http://en.wiktionary.org/wiki/non-existant

It seems so. My bad.

>> +test_expect_success 'proper error on non-accessible files' '
>> +	chmod -r .git/config &&
>> +	test_when_finished "chmod +r .git/config" &&
>> +	echo "Error (-1) reading configuration file .git/config." >expect &&
>> +	test_expect_code 2 test-config configset_get_value foo.bar .git/config 2>actual &&
>> +	test_cmp expect actual
>> +'
>
> Doesn't this one need some prerequisite?

My bad too ;-). There should have been SANITY,POSIXPERM I guess (Tanay:
search "prereq" in t/README if you don't see what we're talking about).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]