René Scharfe wrote:
> Signed-off-by: Rene Scharfe <l.s.r@xxxxxx>
> ---
> fast-import.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Before:
$ size git-fast-import
text data bss dec hex filename
804138 6768 754160 1565066 17e18a git-fast-import
After:
$ size git-fast-import
text data bss dec hex filename
804154 6768 754160 1565082 17e19a git-fast-import
So this makes the text size worse on this machine (amd64, building
with gcc 4.8.2 -O2). That's probably because the old code does 'call
memcmp', while the new code inlines it. Inlining is presumably the
better choice.
More importantly, the new code is more readable.
For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html