Re: [msysGit] [PATCH 4/6] t4210: skip command-line encoding tests on mingw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal <kasal@xxxxxx> wrote:
> From: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx>
>
> On Windows the application command line is provided as unicode and in
> mingw-git we convert that to utf-8. So these tests that require a iso-8859-1
> input are being subverted by the encoding transformations we perform and
> should be skipped.
>
> Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Stepan Kasal <kasal@xxxxxx>
> ---
>  t/t4210-log-i18n.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t4210-log-i18n.sh b/t/t4210-log-i18n.sh
> index 52a7472..9110404 100755
> --- a/t/t4210-log-i18n.sh
> +++ b/t/t4210-log-i18n.sh
> @@ -34,7 +34,7 @@ test_expect_success 'log --grep searches in log output encoding (utf8)' '
>         test_cmp expect actual
>  '
>
> -test_expect_success 'log --grep searches in log output encoding (latin1)' '
> +test_expect_success NOT_MINGW 'log --grep searches in log output encoding (latin1)' '
>         cat >expect <<-\EOF &&
>         latin1
>         utf8
> @@ -43,7 +43,7 @@ test_expect_success 'log --grep searches in log output encoding (latin1)' '
>         test_cmp expect actual
>  '
>
> -test_expect_success 'log --grep does not find non-reencoded values (utf8)' '
> +test_expect_success NOT_MINGW 'log --grep does not find non-reencoded values (utf8)' '

Perhaps these checks would be more readable a few years in the future,
if we make a separate capability along the lines of
NON_UNICODE_LOCALE?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]