Am 17.07.2014 20:41, schrieb Junio C Hamano: > Stepan Kasal <kasal@xxxxxx> writes: > >> From: Johannes Schindelin <johannes.schindelin@xxxxxx> >> >> ... because that does not work in MinGW. >> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> >> Signed-off-by: Stepan Kasal <kasal@xxxxxx> >> --- >> t/t0081-line-buffer.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh >> index bd83ed3..25dba00 100755 >> --- a/t/t0081-line-buffer.sh >> +++ b/t/t0081-line-buffer.sh >> @@ -29,7 +29,7 @@ test_expect_success '0-length read, send along greeting' ' >> test_cmp expect actual >> ' >> >> -test_expect_success 'read from file descriptor' ' >> +test_expect_success NOT_MINGW 'read from file descriptor' ' >> rm -f input && >> echo hello >expect && >> echo hello >input && > > Hmm, the point of this test seems to be to exercise buffer_fdinit(), > instead of buffer_init(), and the file descriptor does not have to > be "4" for the purpose of the test, no? > > Is what is broken on MinGW redirecting arbitrary file descrptors? Yes. 0, 1 and 2 work (vie GetStdHandle), but anything else is handled by the C-runtime. And as MSYS.dll (bash) and MSVCRT.dll (git) do it in different ways, it doesn't work. > - echo copy 6 | > - test-line-buffer "&4" 4<input >actual && > + test-line-buffer "&0" <input >actual && test-line-buffer already reads commands ("copy 6") from stdin, so stdin cannot be reused for the data stream, unfortunately. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html