Re: [PATCH 1/2] MinGW: fix compile error due to missing ELOOP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 16.07.2014 01:42, schrieb Jonathan Nieder:
> Karsten Blees wrote:
> 
>> MinGW and MSVC before 2010 don't define ELOOP, use EMLINK (aka "Too many
>> links") instead.
> [...]
>> +#ifndef ELOOP
>> +#define ELOOP EMLINK
>> +#endif
> 
> This could use
> 
> 	#define ELOOP WSAELOOP
> 
> as an alternative.  But it shouldn't matter since git doesn't look for
> EMLINK anywhere (EMLINK = 31, WSAELOOP = wsabaseerr+62 = 10062).
> 
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
> 

It matters when we report the error to the user (i.e. via die_errno):

strerror(EMLINK) -> "Too many links"
strerror(10062)  -> "Unknown error"

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]