On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote: > +static void error_bad_sort_config(const char *err, va_list params) > +{ > + vreportf("warning: tag.sort has ", err, params); > +} This feels a little like an abuse of the "prefix" field of vreportf, but as you probably saw in my "for fun" patch, doing it right means formatting into a buffer and then reformatting that (which we're already doing again in vreportf, but less flexibly). I dunno. At any rate, this should be marked for translation, no? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html