Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 13, 2014 at 1:22 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>
>>> +       (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit --interactive -m foo
>>
>> Broken &&-chain.
>>
>> Would a printf make this more readable?
>>
>>     printf "p\n1\n\ns\nn\ny\nq\n" | git commt ... &&
>>
>> Perhaps not.
>
> But
>
>         printf "%s\n" p 1 "" s n y q
>
> is vastly more readable, I would think.

Yes, that's much nicer (and I should have thought of it myself
considering that I made effectively the same suggestion elsewhere
[1]).

> Don't we have test_write_lines which is exactly that, though?

Indeed, that's even better.

[1]: http://thread.gmane.org/gmane.comp.version-control.git/233260/focus=234499
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]