Re: [PATCH v7 2/2] test-config: Add tests for the config_set API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tanay Abhra <tanayabh@xxxxxxxxx> writes:

> +test_expect_success 'find value with misspelled key' '
> +	test_must_fail check "my.fOo Bar.hi" "Value not found for \"my.fOo Bar.hi\""
> +'

Sorry, this is still not right. You're checking that either test-config
OR test_cmp fails. You want to check both.

Basically, you can't use the "check" helper here. Your v5 was right for
this test:

test_expect_success 'find value with misspelled key' '
	echo "Value not found for \"my.fOo Bar.hi\"" >expect &&
	test_must_fail test-config get_value "my.fOo Bar.hi" >actual &&
	test_cmp expect actual
'


-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]