Nicolas Pitre <nico@xxxxxxx> writes: >> I think the only way to do with this is to have the Makefile detect >> if -D_FILE_OFFSET_BITS=64 is required to be added to CFLAGS based on >> some rule (e.g. uname output?), then add that to CFLAGS when needed. > > Why not simply defining _FILE_OFFSET_BITS=64 unconditionally? > > It certainly won't cause GIT to explode if compiled against something > else than glibc. I like the simplicity of that approach. Like this? diff --git a/git-compat-util.h b/git-compat-util.h index 105ac28..dd5f369 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -1,6 +1,8 @@ #ifndef GIT_COMPAT_UTIL_H #define GIT_COMPAT_UTIL_H +#define _FILE_OFFSET_BITS 64 + #ifndef FLEX_ARRAY #if defined(__GNUC__) && (__GNUC__ < 3) #define FLEX_ARRAY 0 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html